Skip to content

fix: add MX Master 4 device to known logi devices#38

Merged
thisislvca merged 1 commit intoTomBadash:masterfrom
awkure:fix/detect-mx-master-4
Mar 23, 2026
Merged

fix: add MX Master 4 device to known logi devices#38
thisislvca merged 1 commit intoTomBadash:masterfrom
awkure:fix/detect-mx-master-4

Conversation

@awkure
Copy link
Copy Markdown
Contributor

@awkure awkure commented Mar 22, 2026

Summary

Registers the Logitech MX Master 4 in the known-device catalog so Mouser can resolve it by USB product ID and by common HID product strings, using the existing mx_master UI layout.

Changes

  • core/logi_devices.py: Add a LogiDeviceSpec for mx_master_4 with product ID 0xB042, aliases (including “MX Master 4 for Mac”, MX_Master_4, and “for Business”), and ui_layout="mx_master".
  • tests/test_logi_devices.py: Add unit tests that assert resolution by product ID and by HID-style product name.

@Thxlx
Copy link
Copy Markdown

Thxlx commented Mar 22, 2026

Thank you. Was working on the same. This doesn't work on macos for me. There is more configuration needed in mouse_hook.py so that the Action Button works.

add _BTN_GESTURE = 6 in Line 918
add

elif btn == _BTN_GESTURE:
self._on_hid_gesture_down()
should_block = True

in line 1337

add

elif btn == _BTN_GESTURE:
self._on_hid_gesture_up()
should_block = True

in line 1358

@thisislvca thisislvca merged commit c9bd6e3 into TomBadash:master Mar 23, 2026
1 check passed
@thisislvca
Copy link
Copy Markdown
Collaborator

@Thxlx Put up a follow-up for this here: #42

it wires macOS button 6 into the gesture handlers in mouse_hook.py and adds a regression test around that path.

if you get a chance, can you try that PR on your setup and let me know if the action button works there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants